From 7934cf9aeaac0850523edecc69a6e3427df64095 Mon Sep 17 00:00:00 2001 From: Owen Taylor Date: Wed, 27 Jan 1999 23:49:34 +0000 Subject: [PATCH] Remove TimJ's checks for already being mapped or hidden. See the ICCCM's Tue Jan 26 14:02:50 1999 Owen Taylor * gdk/gdkwindow.c (gdk_window_show/hide): Remove TimJ's checks for already being mapped or hidden. See the ICCCM's section on state changes for why this is a bad idea. --- ChangeLog | 7 +++++++ ChangeLog.pre-2-0 | 7 +++++++ ChangeLog.pre-2-10 | 7 +++++++ ChangeLog.pre-2-2 | 7 +++++++ ChangeLog.pre-2-4 | 7 +++++++ ChangeLog.pre-2-6 | 7 +++++++ ChangeLog.pre-2-8 | 7 +++++++ gdk/gdkwindow.c | 4 ++-- gdk/x11/gdkwindow-x11.c | 4 ++-- 9 files changed, 53 insertions(+), 4 deletions(-) diff --git a/ChangeLog b/ChangeLog index 1f0dbe9765..5d6ca7eea5 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,10 @@ +Tue Jan 26 14:02:50 1999 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_show/hide): Remove TimJ's + checks for already being mapped or hidden. See + the ICCCM's section on state changes for why this + is a bad idea. + Wed Jan 27 17:05:40 1999 Owen Taylor * Separate out GLIB_LIBS and GLIB_DEPLIBS. This diff --git a/ChangeLog.pre-2-0 b/ChangeLog.pre-2-0 index 1f0dbe9765..5d6ca7eea5 100644 --- a/ChangeLog.pre-2-0 +++ b/ChangeLog.pre-2-0 @@ -1,3 +1,10 @@ +Tue Jan 26 14:02:50 1999 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_show/hide): Remove TimJ's + checks for already being mapped or hidden. See + the ICCCM's section on state changes for why this + is a bad idea. + Wed Jan 27 17:05:40 1999 Owen Taylor * Separate out GLIB_LIBS and GLIB_DEPLIBS. This diff --git a/ChangeLog.pre-2-10 b/ChangeLog.pre-2-10 index 1f0dbe9765..5d6ca7eea5 100644 --- a/ChangeLog.pre-2-10 +++ b/ChangeLog.pre-2-10 @@ -1,3 +1,10 @@ +Tue Jan 26 14:02:50 1999 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_show/hide): Remove TimJ's + checks for already being mapped or hidden. See + the ICCCM's section on state changes for why this + is a bad idea. + Wed Jan 27 17:05:40 1999 Owen Taylor * Separate out GLIB_LIBS and GLIB_DEPLIBS. This diff --git a/ChangeLog.pre-2-2 b/ChangeLog.pre-2-2 index 1f0dbe9765..5d6ca7eea5 100644 --- a/ChangeLog.pre-2-2 +++ b/ChangeLog.pre-2-2 @@ -1,3 +1,10 @@ +Tue Jan 26 14:02:50 1999 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_show/hide): Remove TimJ's + checks for already being mapped or hidden. See + the ICCCM's section on state changes for why this + is a bad idea. + Wed Jan 27 17:05:40 1999 Owen Taylor * Separate out GLIB_LIBS and GLIB_DEPLIBS. This diff --git a/ChangeLog.pre-2-4 b/ChangeLog.pre-2-4 index 1f0dbe9765..5d6ca7eea5 100644 --- a/ChangeLog.pre-2-4 +++ b/ChangeLog.pre-2-4 @@ -1,3 +1,10 @@ +Tue Jan 26 14:02:50 1999 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_show/hide): Remove TimJ's + checks for already being mapped or hidden. See + the ICCCM's section on state changes for why this + is a bad idea. + Wed Jan 27 17:05:40 1999 Owen Taylor * Separate out GLIB_LIBS and GLIB_DEPLIBS. This diff --git a/ChangeLog.pre-2-6 b/ChangeLog.pre-2-6 index 1f0dbe9765..5d6ca7eea5 100644 --- a/ChangeLog.pre-2-6 +++ b/ChangeLog.pre-2-6 @@ -1,3 +1,10 @@ +Tue Jan 26 14:02:50 1999 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_show/hide): Remove TimJ's + checks for already being mapped or hidden. See + the ICCCM's section on state changes for why this + is a bad idea. + Wed Jan 27 17:05:40 1999 Owen Taylor * Separate out GLIB_LIBS and GLIB_DEPLIBS. This diff --git a/ChangeLog.pre-2-8 b/ChangeLog.pre-2-8 index 1f0dbe9765..5d6ca7eea5 100644 --- a/ChangeLog.pre-2-8 +++ b/ChangeLog.pre-2-8 @@ -1,3 +1,10 @@ +Tue Jan 26 14:02:50 1999 Owen Taylor + + * gdk/gdkwindow.c (gdk_window_show/hide): Remove TimJ's + checks for already being mapped or hidden. See + the ICCCM's section on state changes for why this + is a bad idea. + Wed Jan 27 17:05:40 1999 Owen Taylor * Separate out GLIB_LIBS and GLIB_DEPLIBS. This diff --git a/gdk/gdkwindow.c b/gdk/gdkwindow.c index 601c748943..c3fd225817 100644 --- a/gdk/gdkwindow.c +++ b/gdk/gdkwindow.c @@ -742,7 +742,7 @@ gdk_window_show (GdkWindow *window) g_return_if_fail (window != NULL); private = (GdkWindowPrivate*) window; - if (!private->destroyed && !private->mapped) + if (!private->destroyed) { private->mapped = TRUE; XRaiseWindow (private->xdisplay, private->xwindow); @@ -758,7 +758,7 @@ gdk_window_hide (GdkWindow *window) g_return_if_fail (window != NULL); private = (GdkWindowPrivate*) window; - if (!private->destroyed && private->mapped) + if (!private->destroyed) { private->mapped = FALSE; XUnmapWindow (private->xdisplay, private->xwindow); diff --git a/gdk/x11/gdkwindow-x11.c b/gdk/x11/gdkwindow-x11.c index 601c748943..c3fd225817 100644 --- a/gdk/x11/gdkwindow-x11.c +++ b/gdk/x11/gdkwindow-x11.c @@ -742,7 +742,7 @@ gdk_window_show (GdkWindow *window) g_return_if_fail (window != NULL); private = (GdkWindowPrivate*) window; - if (!private->destroyed && !private->mapped) + if (!private->destroyed) { private->mapped = TRUE; XRaiseWindow (private->xdisplay, private->xwindow); @@ -758,7 +758,7 @@ gdk_window_hide (GdkWindow *window) g_return_if_fail (window != NULL); private = (GdkWindowPrivate*) window; - if (!private->destroyed && private->mapped) + if (!private->destroyed) { private->mapped = FALSE; XUnmapWindow (private->xdisplay, private->xwindow); -- 2.30.2